cut: set exit code to 1 if dir is specified

uutils · Jan 26, 2024 · c8cd355 · c8cd355
1 parent 5bd00eb
commit c8cd355
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/uu/cut/src/cut.rs b/src/uu/cut/src/cut.rs
@@ -11,7 +11,7 @@ use std::fs::File;
 use std::io::{stdin, stdout, BufReader, BufWriter, IsTerminal, Read, Write};
 use std::path::Path;
 use uucore::display::Quotable;
-use uucore::error::{FromIo, UResult, USimpleError};
+use uucore::error::{set_exit_code, FromIo, UResult, USimpleError};
 use uucore::line_ending::LineEnding;
 
 use self::searcher::Searcher;
@@ -319,6 +319,7 @@ fn cut_files(mut filenames: Vec<String>, mode: &Mode) {
 
             if path.is_dir() {
                 show_error!("{}: Is a directory", filename.maybe_quote());
+                set_exit_code(1);
                 continue;
             }
 

diff --git a/tests/by-util/test_cut.rs b/tests/by-util/test_cut.rs
@@ -219,7 +219,8 @@ fn test_is_a_directory() {
 
     ucmd.arg("-b1")
         .arg("some")
-        .run()
+        .fails()
+        .code_is(1)
         .stderr_is("cut: some: Is a directory\n");
 }
 
@@ -228,7 +229,8 @@ fn test_no_such_file() {
     new_ucmd!()
         .arg("-b1")
         .arg("some")
-        .run()
+        .fails()
+        .code_is(1)
         .stderr_is("cut: some: No such file or directory\n");
 }