timeout: Make use of fundu in timeout to parse the KILL_AFTER and DURATION arguments
#4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joining7943
force-pushed
the
timeout-make-use-of-fundu
branch
from
663acb7 to
0209842
Compare
Joining7943
force-pushed
the
timeout-make-use-of-fundu
branch
from
0209842 to
de08cd3
Compare
|
No activity for a while, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title describes, make use of fundu which is faster by maintaining full precision of the input arguments and has nicer error messages if something goes wrong during the parsing.