libstdbuf: remove crash macro #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is however a bit of a tricky crate. Since this crate is injected into processes, I think it might actually best if this doesn't rely on uucore. In this case I think we should just check what error messages GNU gives and just use eprintln! and std::process::exit to match that.
@sylvestre do you agree?
Edit: Actually, I think we should probably only print a warning if we fail to parse the value.
|
Added some changes, including no longer relying on |
cakebaker
force-pushed
the
libstdbuf-remove-crash-macro
branch
from
1761a7d to
0db8fbb
Compare
|
GNU testsuite comparison: |
|
Ah right, thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue: #5487
Removes the
crash!macro from libstdbuf