`fmt`: a collection of small refactors #5592

tertsdiepraam · 2023-11-28T11:38:30Z

I saw some opportunities to clean up fmt. Each commit contains a small atomic improvement. I recommend reviewing the commits separately.

This should not have changed any of the behaviour of fmt it's all just small changes.

github-actions · 2023-11-28T12:15:12Z

GNU testsuite comparison:

GNU test failed: tests/tail/inotify-dir-recreate. tests/tail/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

tertsdiepraam added 7 commits November 28, 2023 11:40

fmt: clean up some small bits

01c32a5

fmt: extract determining options to separate function

d78923e

fmt: merge prefix and use_prefix options (same for anti_prefix)

f5206ce

fmt: refactor width and goal calculation

96ca5e6

fmt: clean up imports

8a49453

fmt: put options into module and change static to const

0b4d4b6

fmt: inline parse_arguments function

2a8f4ec

tertsdiepraam force-pushed the fmt-small-refactor branch from d081130 to 2a8f4ec Compare November 28, 2023 11:42

cakebaker approved these changes Nov 28, 2023

View reviewed changes

cakebaker merged commit 32bc2e4 into uutils:main Nov 28, 2023
49 of 53 checks passed

cakebaker mentioned this pull request Nov 28, 2023

fmt: rename pfxind_end -> prefix_indent_end #5593

Merged

Provide feedback