Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: if a file can't be remove, still continue to delete the content #5751

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

rm: if a file can't be remove, still continue to delete the content #5751

wants to merge 4 commits into from

Conversation

sylvestre
Copy link
Contributor

tested by: tests/rm/rm1.sh

@sylvestre sylvestre changed the title rm: if an file can't be remove, still continue to delete the content rm: if a file can't be remove, still continue to delete the content Dec 30, 2023
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/pwd/pwd-long. tests/pwd/pwd-long is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/cycle. tests/rm/cycle is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/deep-2. tests/rm/deep-2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/fail-eacces. tests/rm/fail-eacces is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/unread2. tests/rm/unread2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/unreadable. tests/rm/unreadable is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre commented Dec 30, 2023
View reviewed changes
.github/workflows/ignore-intermittent.txt
@@ -1,3 +1,2 @@
tests/tail/inotify-dir-recreate
tests/misc/timeout
tests/rm/rm1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intermittent was depending on how the removal was done. If it is in alphabetic order, it would not work but in random, it could

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/pwd/pwd-long. tests/pwd/pwd-long is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/deep-2. tests/rm/deep-2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/unreadable. tests/rm/unreadable is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm1 is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/pwd/pwd-long. tests/pwd/pwd-long is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/deep-2. tests/rm/deep-2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/unread2. tests/rm/unread2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm1 is no longer failing!

@sylvestre sylvestre marked this pull request as draft December 30, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sylvestre