hashsum: also escape/unescape files with checks #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
commented
Jan 21, 2024
| @@ -100,9 +100,9 @@ cp "${UU_BUILD_DIR}/install" "${UU_BUILD_DIR}/ginstall" # The GNU tests rename t | |||
| # Create *sum binaries | |||
| for sum in b2sum b3sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum; do | |||
| sum_path="${UU_BUILD_DIR}/${sum}" | |||
| test -f "${sum_path}" || cp "${UU_BUILD_DIR}/hashsum" "${sum_path}" | |||
| test -f "${sum_path}" || (cd ${UU_BUILD_DIR} && ln -s "hashsum" "${sum}") | |||
There was a problem hiding this comment.
otherwise, I was testing always the same program :)
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
md5sum-escape-bis
branch
from
72f3335 to
f8a0be0
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Jan 25, 2024
cakebaker
reviewed
Jan 25, 2024
cakebaker
reviewed
Jan 25, 2024
|
GNU testsuite comparison: |
Plus: it won't cp new md5
Should fix tests/cksum/md5sum-bsd.sh
Co-authored-by: Daniel Hofstetter <[email protected]>
sylvestre
force-pushed
the
md5sum-escape-bis
branch
from
378aeaf to
8652fd0
Compare
|
GNU testsuite comparison: |
Co-authored-by: Daniel Hofstetter <[email protected]>
Co-authored-by: Daniel Hofstetter <[email protected]>
|
GNU testsuite comparison: |
Great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix tests/cksum/md5sum-bsd.sh