Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE.GPL for colors.rs #5876

Closed

Conversation

michel-slm
Copy link
Contributor

colors.rs is generated by calling GNU coreutils' dircolors, and contains its license header. Bundle the license file as required, and document this in README.md

To test, first comment out the dependency on uucore, since the required colors feature is not in 0.0.23. Then:

michel in src/uu/dircolors on  dircolors-add-gnu-coreutils-license [!+] is 📦 v0.0.24 via 🦀 v1.75.0 took 10s
⬢ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging uu_dircolors v0.0.24 (/home/michel/src/github/uutils/coreutils/src/uu/dircolors)
    Updating crates.io index
    Packaged 9 files, 64.1KiB (21.0KiB compressed)

michel in src/uu/dircolors on  dircolors-add-gnu-coreutils-license [!+] is 📦 v0.0.24 via 🦀 v1.75.0
⬢ [fedora-toolbox:38] ❯ bsdtar tf ../../../target/package/uu_dircolors-0.0.24.crate | grep LICENSE
uu_dircolors-0.0.24/LICENSE
uu_dircolors-0.0.24/LICENSE.GPL

`colors.rs` is generated by calling GNU coreutils' dircolors, and
contains its license header. Bundle the license file as required,
and document this in README.md

To test, first comment out the dependency on uucore, since the required
`colors` feature is not in 0.0.23. Then:

```
michel in src/uu/dircolors on  dircolors-add-gnu-coreutils-license [!+] is 📦 v0.0.24 via 🦀 v1.75.0 took 10s
⬢ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
   Packaging uu_dircolors v0.0.24 (/home/michel/src/github/uutils/coreutils/src/uu/dircolors)
    Updating crates.io index
    Packaged 9 files, 64.1KiB (21.0KiB compressed)

michel in src/uu/dircolors on  dircolors-add-gnu-coreutils-license [!+] is 📦 v0.0.24 via 🦀 v1.75.0
⬢ [fedora-toolbox:38] ❯ bsdtar tf ../../../target/package/uu_dircolors-0.0.24.crate | grep LICENSE
uu_dircolors-0.0.24/LICENSE
uu_dircolors-0.0.24/LICENSE.GPL
```

Signed-off-by: Michel Lind <[email protected]>
@michel-slm
Copy link
Contributor Author

@sylvestre
Copy link
Contributor

I am not a lawyer but it is a list of configuration parameters for compatibility purpose, not code

https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/colors.rs

colors.rs is generated by calling GNU coreutils' dircolors, and contains its license header.

not the case anymore since https://github.com/uutils/coreutils/pull/5611/files

@sylvestre sylvestre closed this Jan 24, 2024
@sylvestre
Copy link
Contributor

note: a quick search shows that these data can be found in many different places, licenses and languages
https://github.com/search?q=STICKY_OTHER_WRITABLE&type=code

@michel-slm
Copy link
Contributor Author

I am not a lawyer but it is a list of configuration parameters for compatibility purpose, not code

https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/colors.rs

colors.rs is generated by calling GNU coreutils' dircolors, and contains its license header.

not the case anymore since https://github.com/uutils/coreutils/pull/5611/files

oh, excellent, thanks!

@sylvestre
Copy link
Contributor

welcome :)

@michel-slm
Copy link
Contributor Author

@sylvestre should the README.md be deleted then? https://github.com/uutils/coreutils/blob/main/src/uu/dircolors/README.md -- it still mentions running GNU dircolors until the tests pass

@sylvestre
Copy link
Contributor

sure, i forgot about this file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants