Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd: unset O_DIRECT flag on last chunk if irregular sized #6080

Closed
wants to merge 80 commits into from
Closed

dd: unset O_DIRECT flag on last chunk if irregular sized #6080

wants to merge 80 commits into from

Conversation

cre4ture
Copy link
Contributor

addresses #6078 (detailed, please read)

@cre4ture cre4ture changed the title unset O_DIRECT flag on last chunk if irregular sized dd: unset O_DIRECT flag on last chunk if irregular sized Mar 15, 2024
@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 2b38f71 to 4e54ba9 Compare March 15, 2024 16:59
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@sylvestre
Copy link
Contributor

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

nice :)

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 4e54ba9 to 944f36a Compare March 15, 2024 19:03
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

@sylvestre
Copy link
Contributor

is it possible to add a test for this? thanks

@cre4ture
Copy link
Contributor Author

cre4ture commented Mar 16, 2024 •
edited
Loading

sure. I can do that.
But I have a general question:
Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch 2 times, most recently from b586180 to b1986d0 Compare March 17, 2024 16:34
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@sylvestre
Copy link
Contributor

Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

We want to test it with own first. It is much faster to run ours. And way easier to hack.

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from b1986d0 to f6266b8 Compare March 17, 2024 18:55
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from f6266b8 to 3b61dbd Compare March 17, 2024 20:16
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

@sylvestre
Copy link
Contributor

could you please rebase this PR? thanks

@cre4ture
Copy link
Contributor Author

I will rebase it. But the tests on android are not yet green. Merging needs to wait...

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 3b61dbd to 41bb74f Compare March 18, 2024 22:32
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 6065e55 to c649e69 Compare March 18, 2024 23:54
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@cre4ture cre4ture marked this pull request as draft March 19, 2024 20:49
@cre4ture cre4ture mentioned this pull request Mar 20, 2024
Merged
@cre4ture cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from a0cda49 to ba3fe6f Compare April 25, 2024 21:12
@cre4ture
set CARGO_TARGET_DIR env variable for cargo install step
fb61c01 
this way the retry can re-use previously build results
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

1 similar comment
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/dd/direct is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

@cre4ture cre4ture closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cre4ture @sylvestre