-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix/Nixos development #6947
Open
RenjiSann
wants to merge
3
commits into
uutils:main
Choose a base branch
from
RenjiSann:nixos-devel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nix/Nixos development #6947
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
if ! has nix_direnv_version || ! nix_direnv_version 3.0.6; then | ||
source_url "https://raw.githubusercontent.com/nix-community/nix-direnv/3.0.6/direnvrc" "sha256-RYcUJaRMf8oF5LznDrlCXbkOQrywm0HDv1VjYGaJGdM=" | ||
fi | ||
|
||
use flake |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,6 @@ lib*.a | |
*.iml | ||
### macOS ### | ||
.DS_Store | ||
|
||
### direnv ### | ||
/.direnv/ |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
{ | ||
inputs = { | ||
nixpkgs.url = "github:nixos/nixpkgs"; | ||
flake-utils.url = "github:numtide/flake-utils"; | ||
}; | ||
|
||
outputs = { | ||
self, | ||
nixpkgs, | ||
flake-utils, | ||
}: | ||
flake-utils.lib.eachDefaultSystem (system: let | ||
pkgs = nixpkgs.legacyPackages.${system}; | ||
libselinuxPath = with pkgs; | ||
lib.makeLibraryPath [ | ||
libselinux | ||
]; | ||
libaclPath = with pkgs; | ||
lib.makeLibraryPath [ | ||
acl | ||
]; | ||
|
||
build_deps = with pkgs; [ | ||
clang | ||
llvmPackages.bintools | ||
rustup | ||
|
||
pre-commit | ||
|
||
# debugging | ||
gdb | ||
]; | ||
gnu_testing_deps = with pkgs; [ | ||
autoconf | ||
automake | ||
bison | ||
gnum4 | ||
gperf | ||
gettext | ||
texinfo | ||
]; | ||
in { | ||
devShell = pkgs.mkShell { | ||
buildInputs = build_deps ++ gnu_testing_deps; | ||
|
||
RUSTC_VERSION = "1.75"; | ||
LIBCLANG_PATH = pkgs.lib.makeLibraryPath [pkgs.llvmPackages_latest.libclang.lib]; | ||
shellHook = '' | ||
export PATH=$PATH:''${CARGO_HOME:-~/.cargo}/bin | ||
export PATH=$PATH:''${RUSTUP_HOME:-~/.rustup}/toolchains/$RUSTC_VERSION-x86_64-unknown-linux-gnu/bin/ | ||
''; | ||
|
||
SELINUX_INCLUDE_DIR = ''${pkgs.libselinux.dev}/include''; | ||
SELINUX_LIB_DIR = libselinuxPath; | ||
SELINUX_STATIC = "0"; | ||
|
||
# Necessary to build GNU. | ||
LDFLAGS = ''-L ${libselinuxPath} -L ${libaclPath}''; | ||
|
||
# Add precompiled library to rustc search path | ||
RUSTFLAGS = | ||
(builtins.map (a: ''-L ${a}/lib'') [ | ||
]) | ||
++ [ | ||
''-L ${libselinuxPath}'' | ||
''-L ${libaclPath}'' | ||
]; | ||
}; | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't like the hardcoded versions here?
is there a better way?
or can we just land flake.nix ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To explain what's going on, direnv naturally supports the
use flake
directive. However, with the default implementation, we are doomed to re-computing the flake each time we get in/out of the directory.This line allows to use an implementation that is made by the nix community and which caches the flake's build.
As for the version check, I guess we could remove it. I'm not very familiar with the previous versions, so I don't really know what this will imply.