Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq: add a lower bound for exponents #7145

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

alexs-sh
Copy link
Contributor

@alexs-sh alexs-sh commented Jan 16, 2025

About

This PR adds a lower bound for the minimum exponent value to prevent overflow when parsing BigDecimal numbers.

Before

cargo run -- seq 1e-9223372036854775808
seq: invalid floating point argument: '1e-9223372036854775808'

After

cargo run -- seq 1e-9223372036854775808

Expected

seq 1e-9223372036854775808

Thank you

Add bounds for exponents to avoid overflow issues for inputs like 'seq
1e-9223372036854775808'
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/stdbuf. tests/misc/stdbuf is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/seq/seq-precision is no longer failing!

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/seq/seq-precision is no longer failing!

Excellent!

@sylvestre sylvestre merged commit 6060a3e into uutils:main Jan 16, 2025
47 of 49 checks passed
sylvestre added a commit that referenced this pull request Jan 16, 2025
sylvestre added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants