sort: support percent arguments to -S option #7181
Merged
+116
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Add support for parsing percent arguments to the `-S` option. The given percentage specifies a percentage of the total physical memory. For Linux, the total physical memory is read from `/proc/meminfo`. The feature is not yet implemented for other systems. In order to implement the feature, the `uucore::parser::parse_size` function was updated to recognize strings of the form `NNN%`. Fixes uutils#3500
jfinkels
force-pushed
the
sort-mem-percent
branch
from
b6cd548 to
94c772c
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 23, 2025
|
|
||
| /// Get the total number of bytes of physical memory. | ||
| /// | ||
| /// TODO Implement this for non-Linux systems. |
There was a problem hiding this comment.
could you please open a new issue for this?
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing percent arguments to the
-Soption. The givenpercentage specifies a percentage of the total physical memory. For
Linux, the total physical memory is read from
/proc/meminfo. Thefeature is not yet implemented for other systems.
In order to implement the feature, the
uucore::parser::parse_sizefunction was updated to recognize strings of the form
NNN%.Fixes #3500