Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printf: fix octal escape parsing #7210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aryalaadi
Copy link

fixes #7202

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

Some jobs are failing. Could you please also add tests? :)

@aryalaadi
Copy link
Author

Some jobs are failing. Could you please also add tests? :)

where do I check which passing test has failed? I think I have a good idea why it's failing but I dont know which test it is

@cakebaker
Copy link
Contributor

It looks like all tests pass, though there are two jobs failing in the CI because you didn't run cargo fmt.

@aryalaadi
Copy link
Author

aryalaadi commented Jan 27, 2025

It looks like all tests pass, though there are two jobs failing in the CI because you didn't run cargo fmt.

Warning: Changes from 'main': PASS -1 / FAIL +1 / ERROR +0 / SKIP +0

I see three failing jobs, and this one says I broke one passing test

@cakebaker
Copy link
Contributor

You can see the reason in an earlier comment from the bot:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

It's a test that unfortunately fails from time to time. It's unrelated to your changes and so you can ignore it :)

fixes uutils#7202 and adds a new test for the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printf: fails to interpret octal escape sequence with leading 0 in string literal
3 participants