Getting rid of duplicate ccs bugfix branches #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* automatic directory creation * dummy ports now available alongside real COM ports * define SUBSYSTEMS as module-level constant * cosmetics and docstrings
* change indicator circle to bright green * omit erroneous logging call after closing log file * add OFF message before closing file * adjust vtrx plot limit
* TODO note * replace png indicators with canvas circles and standardize labels * fix pressure plot x-axis time formatting * indentation * docstrings. adjust indicator coloring * add exception handling
* default to maximized window * add five keyboard shortcuts * bind Ctrl-s to export log * add shortcut help window - F1 * tweak dimension * clean up tab contents * wording
* resize labels proportionally with the frame * spacing and resize method * Add PNG export feature for pressure plot * remove unused MAX_POINTS * add/update docstrings * font resize and bind to parent * add pressure plot time window selection dropdown * additional time options. remove reset button * add 10 hour pressure history tracking * frontend updates * adjust colors
* make logging indicator appearance consistent with other elements * add table for keyboard shortcuts * starting point for VTRX subsystem readme
* lengthen MAX_HISTORY_SECONDS to 1 week * time window note
* add more debug logging calls for visibility during testing * sensor error too aggressive. Only indicate unit error after three consecutive failed readings * adjust minimum temp scale limit. Tone back error classification * quiet down logging * increase missed package tolerance and clean up logs * updated initialization flowchart * updated update_temperature callback flowchart * working on read me for the process_monitor.py * small changes, same as above commit ^ * fixed typos in process_monitor.py readme and added imports to DP16 driver readme * release modbus_lock between units and maintain BASE_DELAY * add poll_all_units flowchart to README * add DP16ProcessMonitor driver init flowchart to README * more small changes to the Readme documentation * reduce connection state check frequency * each unit operation now fully atomic, buffer clearing before each unit read. Simplify error paths * add disconnection check * increase inter-unit poll delay * remove blue coloring * re-enable error counting * consolidate exception handling, reduce Modbus timeout * enforce rate limiting for critical polling error * spelling * remove hard fail for bad STATUS_RUNNING * fix status registers typo * add helper method to distinguish ModbusIOExceptions * remove redundant try-block * unify error handling with minor vs. major threshold * fix constant syntax * remove problematic DISCONNECTED state assignment --------- Co-authored-by: Mark Ruzicka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my bad, merging the two together