CI pipeline testing pipeline config along with tests for G9 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslaffin
reviewed
Jan 28, 2025
.github/workflows/python_tests.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop, feature/ciG9] |
There was a problem hiding this comment.
@mark11778 I think this PR looks pretty much good to go.
It seems unnecessary to have feature/ciG9 included in the push triggers though.
This is a temporary branch and it seems like we shouldn't want that hard-coded here because it'll be deleted after merging?
Would it cause problems to remove this?
There was a problem hiding this comment.
Ope, good catch. Yeah that was just for testing. Ill remove it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated requirements.txt,
workflow dir with the yml file
added ci tests for G9