Feature/machine progress bar #56
Merged
+130
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslaffin
reviewed
Feb 28, 2025
| ), | ||
| 'Oil System': subsystem.OilSubsystem( | ||
| self.frames['Oil System'], | ||
| logger=self.logger | ||
| logger=self.logger, |
There was a problem hiding this comment.
I wonder if we should add a MACHINE_STATUS for the oil system? And for the VTRX system?
It seems like that would give us consistency across all subsystems at basically no cost. As long as we can fit the text.
There was a problem hiding this comment.
Yes Arundhati and I talked about this just now and think this is a great idea
utils.py
Outdated
Comment on lines
409
to
412
| if status_dict is None: | ||
| status_dict = self.MACHINE_STATUS | ||
| self.update_labels(status_dict) | ||
| self.parent.after(self.update_interval, self.update_status) # Schedule the next update |
There was a problem hiding this comment.
this update method is getting called repeatedly even when there are no changes. We'll probably want to track if any status in the dict has actually changed before scheduling the update.
There was a problem hiding this comment.
Awesome it looks like you fixed this in commit 4d3af84
bwalkerMIR
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a machine status progress bar to the dashboard by creating another row. I made this subpanel in utils.py and check for updates from the interlocks and pmon subsystems to determine if they are active or not.