Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin box: Improve for M3 #440

Closed
wants to merge 1 commit into from

Conversation

peter-ha
Copy link
Collaborator

Resolves #398

normal:

Screenshot from 2024-10-20 17-43-59

hovered:

Screenshot from 2024-10-20 17-43-43

pressed:

Screenshot from 2024-10-20 17-44-03

Comments:

  • size of up/down buttons: normal push button size (i.e. height of 40 dp)
  • emphasis: As mentioned in the ticket emphasis is like the very low button emphasis
  • spin box height has been chosen to be the same as the menu height (48 dp). Different
    controls have different heights here, e.g. outlined text field has 56 dp and chips
    only 32 dp. So we could also chose another height here.
  • size of icons: Same as push button icons.
    (Panel size is 40 dp, icon padding is 11 dp, so icon size is 40-2*11=18 dp)

@uwerat
Copy link
Owner

uwerat commented Oct 21, 2024

I adjusted the code to make use of QCursor::pos() - instead of storing the position as skin hint

@uwerat uwerat closed this Oct 21, 2024
@peter-ha
Copy link
Collaborator Author

peter-ha commented Nov 4, 2024

Commits for reference: 932d34a and b7c2b27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QskSpinBox Buttons for Material3
2 participants