Move code

uweseimet · Jan 25, 2025 · 9ac9acd · 9ac9acd
1 parent a25ab37
commit 9ac9acd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cpp/command/command_executor.cpp b/cpp/command/command_executor.cpp
@@ -381,15 +381,15 @@ bool CommandExecutor::Detach(const CommandContext &context, PrimaryDevice &devic
             return context.ReturnLocalizedError(LocalizationKey::ERROR_DETACH);
         }
 
+        // Remove both potential identifiers
+        PropertyHandler::GetInstance().RemoveProperties(fmt::format("{0}{1}:{2}.", PropertyHandler::DEVICE, id, lun));
+        PropertyHandler::GetInstance().RemoveProperties(fmt::format("{0}{1}.", PropertyHandler::DEVICE, id));
+
         // If no LUN is left also delete the controller
         if (!controller->GetLunCount() && !controller_factory.DeleteController(*controller)) {
             return context.ReturnLocalizedError(LocalizationKey::ERROR_DETACH);
         }
 
-        // Remove both potential identifiers
-        PropertyHandler::GetInstance().RemoveProperties(fmt::format("{0}{1}:{2}.", PropertyHandler::DEVICE, id, lun));
-        PropertyHandler::GetInstance().RemoveProperties(fmt::format("{0}{1}.", PropertyHandler::DEVICE, id));
-
         s2p_logger.info("Detached " + identifier);
     }