-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test broken macros #2001
Conversation
…NTEL_LLVM_COMPILER definition
…_TEST_EDGES definition
@danhoeflinger , should we replace the rest of |
I think it is fixed, it is on my TODO list to confirm that, thanks for the reminder. |
@danhoeflinger, @mmichel11 the next question about the usage of // A specific kernel compilation order causes incorrect results on Windows with the DPCPP backend. For now, we reorder
// the test while the issue is being reported to the compiler team. Once it is resolved, this macro can be removed
// or limited to older compiler versions.
#define _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN \
(_MSC_VER && TEST_DPCPP_BACKEND_PRESENT && __INTEL_LLVM_COMPILER <= _PSTL_TEST_LATEST_INTEL_LLVM_COMPILER) |
This fix already prepared by @dmitriy-sobolev in the PR #2000 |
I tested and it's fixed, so the approach in the new PR is correct. |
No description provided.