Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test broken macros #2001

Closed

Conversation

SergeyKopienko
Copy link
Contributor

No description provided.

@SergeyKopienko SergeyKopienko added this to the 2022.8.0 milestone Jan 15, 2025
@SergeyKopienko
Copy link
Contributor Author

@danhoeflinger , should we replace the rest of _PSTL_TEST_COMPARISON_BROKEN usages like I already made in this PR?
Were these error fixed?

@danhoeflinger
Copy link
Contributor

@danhoeflinger , should we replace the rest of _PSTL_TEST_COMPARISON_BROKEN usages like I already made in this PR? Were these error fixed?

I think it is fixed, it is on my TODO list to confirm that, thanks for the reminder.

@SergeyKopienko
Copy link
Contributor Author

@danhoeflinger, @mmichel11 the next question about the usage of _PSTL_TEST_LATEST_INTEL_LLVM_COMPILER in _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN definition: has it been fixed too?

// A specific kernel compilation order causes incorrect results on Windows with the DPCPP backend. For now, we reorder
// the test while the issue is being reported to the compiler team. Once it is resolved, this macro can be removed
// or limited to older compiler versions.
#define _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN                                                                  \
    (_MSC_VER && TEST_DPCPP_BACKEND_PRESENT && __INTEL_LLVM_COMPILER <= _PSTL_TEST_LATEST_INTEL_LLVM_COMPILER)

@SergeyKopienko
Copy link
Contributor Author

This fix already prepared by @dmitriy-sobolev in the PR #2000

@SergeyKopienko SergeyKopienko deleted the dev/skopienko/fix_broken_std_complex_tests branch January 16, 2025 11:18
@mmichel11
Copy link
Contributor

@danhoeflinger, @mmichel11 the next question about the usage of _PSTL_TEST_LATEST_INTEL_LLVM_COMPILER in _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN definition: has it been fixed too?

// A specific kernel compilation order causes incorrect results on Windows with the DPCPP backend. For now, we reorder
// the test while the issue is being reported to the compiler team. Once it is resolved, this macro can be removed
// or limited to older compiler versions.
#define _PSTL_RED_BY_SEG_WINDOWS_COMPILE_ORDER_BROKEN                                                                  \
    (_MSC_VER && TEST_DPCPP_BACKEND_PRESENT && __INTEL_LLVM_COMPILER <= _PSTL_TEST_LATEST_INTEL_LLVM_COMPILER)

I tested and it's fixed, so the approach in the new PR is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants