Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: nscipione <[email protected]>
  • Loading branch information
s-Nick committed Dec 16, 2024
1 parent b4360f3 commit b88b452
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions docs/building_the_project_with_dpcpp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ or ``clang++`` and ``clang`` respectively when using the Open DPC++ Compiler.
Backends should be enabled by setting ``-DENABLE_<BACKEND_NAME>_BACKEND=True``
for each desired backend. By default, only the ``MKLGPU`` and ``MKLCPU``
backends are enabled. Multiple backends for multiple device vendors can be
enabled at once (albeit with limitations when using oneMath SYCL BLAS and portFFT). The
supported backends for the compilers are given in the table at `oneMath
enabled at once (albeit with limitations when using oneMath generic SYCL BLAS and portFFT).
The supported backends for the compilers are given in the table at `oneMath
supported configurations table
<https://github.com/uxlfoundation/oneMath?tab=readme-ov-file#supported-configurations>`_,
and the CMake option names are given in the table below. Some backends may
Expand Down Expand Up @@ -247,7 +247,7 @@ unsupported configurations.
Pure SYCL backends: generic BLAS and portFFT
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

`Generic BLAS <https://github.com/codeplaysoftware/portBLAS>`_ and `portFFT
`Generic SYCL BLAS <https://github.com/codeplaysoftware/portBLAS>`_ and `portFFT
<https://github.com/codeplaysoftware/portFFT>`_ are experimental pure-SYCL
backends that work on all SYCL targets supported by the DPC++ compiler. Since
they support multiple targets, they cannot be enabled with other backends in the
Expand All @@ -257,7 +257,7 @@ experimental and currently only support a subset of operations and features.
For best performance, both libraries must be tuned. See the individual sections
for more details.

Both oneMath SYCL BLAS and portFFT are used as header-only libraries, and will be
Both generic SYCL BLAS and portFFT are used as header-only libraries, and will be
downloaded automatically if not found.

.. _build_for_generic_blas_dpcpp:
Expand All @@ -270,7 +270,7 @@ enabled by setting ``-DENABLE_GENERIC_BLAS_BACKEND=True``.

By default, the generic BLAS backend is not tuned for any specific device.
This tuning is required to achieve best performance.
OneMath SYCL BLAS can be tuned for a specific hardware target by adding compiler
The generic SYCL BLAS backend can be tuned for a specific hardware target by adding compiler
definitions in 2 ways:

#.
Expand Down Expand Up @@ -438,8 +438,7 @@ Build oneMath for the BLAS domain on a generic SYCL device:
-DENABLE_GENERIC_BLAS_BACKEND=True
Note that this is not a tested configuration. This builds oneMath with the
generic BLAS backend only, for a generic SYCL device supported by the
Open DPC++ project.
generic SYCL BLAS backend only, for a generic SYCL device.

Build oneMath for the DFT domain on a generic SYCL device:

Expand Down

0 comments on commit b88b452

Please sign in to comment.