Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove Conan from documentation #460

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

hjabird
Copy link
Contributor

@hjabird hjabird commented Mar 20, 2024

Description

This is one of the suggested changes in #459.

Checklist

All Submissions

  • [ N/A] Do all unit tests pass locally? Attach a log.
    • I have confirmed that it is still possible to build the project and that the CMake has not been broken. I have not tested the C++ code since no changes have been made.
  • [ N/A] Have you formatted the code using clang-format?

* Support for Conan has been dropped in oneMKL.
* This PR:
  * Removes Conan from the documentation.
  * Removes Conan scripts.
@hjabird
Copy link
Contributor Author

hjabird commented Mar 20, 2024

Pinging @mkrainiuk @mmeterel @vmalia since I think you're best placed to know what we want here.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mkrainiuk mkrainiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good to me. I believe we can also close the discussion about Conan after this change, what do you think @vmalia?

@hjabird
Copy link
Contributor Author

hjabird commented Apr 2, 2024

I'll merge this tomorrow if there are no further comments (@vmalia?).

@hjabird hjabird merged commit 8c907b4 into uxlfoundation:develop Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants