-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub workflow for running unit tests for MKL backend on CPU #483
Conversation
lapack finishes in 30 minutes and blas takes 1.5 hours. All the time is building the tests. Combining multiple tests into a single binary might make testing faster without reducing coverage. |
@hjabird: Added CPU to job name to address: #482 (comment) |
…est runner available
I guess we can also skip building GPU part with |
I made the change. It runs about 25% faster, which makes up for the intel hosted runners being 25% slower than github hosted runners. When you move to onemkl-project org, we can use github hosted runners without contending with other projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have one suggestion.
verbose logging and serial test execution for more readable logs. build time dominates so parallel test is less important. Co-authored-by: Dai-Ni Hsieh <[email protected]>
…ndation#483) Co-authored-by: Dai-Ni Hsieh <[email protected]>
Description
GitHub Actions workflow to run unit tests for MKL/CPU.
I disabled tests that require GPU by excluding tests where the name ends in
gpu
. RNG and DFT domains finish in 10 minutes. I am still waiting for BLAS/LAPACK to finish. We could have nightly testing that runs everything and PR testing that runs a smaller set. Any thoughts on how to reduce the testing for PR's?@mkrainiuk