Replace outdated SYCL_DEVICE_FILTER with ONEAPI_DEVICE_SELECTOR #484
Conversation
|
@dnhsieh-intel Thanks for pointing that out, looks like I missed a few instances in docs/comments. I did a sweep and replaced all the mentions I found of SYCL devices, let me know how that looks. |
Co-authored-by: Dai-Ni Hsieh <[email protected]>
| if(ENABLE_MKLGPU_BACKEND OR ENABLE_CUFFT_BACKEND OR ENABLE_ROCFFT_BACKEND OR ENABLE_PORTFFT_BACKEND) | ||
| list(APPEND DFT_RT_SOURCES "real_fwd_usm") | ||
| list(APPEND DEVICE_FILTERS "gpu") | ||
| list(APPEND DEVICE_FILTERS "level_zero:gpu") |
There was a problem hiding this comment.
I am worried about this. Could you please check CUFFT and ROCFFT backends?
There was a problem hiding this comment.
Done in 1c6b27b. Testing was performed on a temporary branch and the only failures seen were already present in the base interfaces job.
| list(APPEND DEVICE_FILTERS "level_zero:gpu") | ||
| endif() | ||
| if(ENABLE_PORTFFT_BACKEND) | ||
| list(APPEND_DEVICE_FILTERS "*.gpu") |
There was a problem hiding this comment.
Could you please double-check if this should be *.gpu or *:gpu?
There was a problem hiding this comment.
Thanks for the catch and sorry for the mistake, double checked and ran a quick test last night, it should be *:gpu. Change has been made in a5e59a5
Co-authored-by: Dai-Ni Hsieh <[email protected]>
…oundation#484) Co-authored-by: Dai-Ni Hsieh <[email protected]>
…oundation#484) Co-authored-by: Dai-Ni Hsieh <[email protected]>
Background:
Deprecated environment variable SYCL_DEVICE_FILTER is still being used in the oneMKL Interfaces project. This variable has been replaced by ONEAPI_DEVICE_SELECTOR, and this PR finishes this replacement for the oneMKL Interfaces project. The default CPU and GPU that were used with SYCL_DEVICE_FILTER have been replaced with
opencl:cpuandlevel_zero:gpurespectively.Testing:
There are known failures for RNG domain on Windows x86 platforms, and the test log from this case has been attached. These failures are also present in the base repository before these changes, and are expected. There are no additional failures in this branch relative to the base repository.
test_fails.txt