Selective CI based on changes to a domain #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rscohn2
changed the title
.github/workflows/pr.yml
Outdated
| - 'src/${{ matrix.domain}}/**' | ||
| - 'tests/unit_tests/${{ matrix.domain }}/**' | ||
| - CMakeLists.txt | ||
| - '.github/workflows/**' |
There was a problem hiding this comment.
I would also add examples and include directories because we test examples and headers could affect the build.
There was a problem hiding this comment.
I agree. Thanks, @rscohn2 !
There was a problem hiding this comment.
I am looking for a more maintainable way to specify the files that will trigger a test.
Co-authored-by: Dai-Ni Hsieh <[email protected]>
rscohn2
force-pushed
the
dev/selective-build
branch
from
8587204 to
d6a5ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Selective CI based on changes to a domain. Requested by @sknepper.
I tested that the filter works by making changes to RNG and DFT, src and tests directories. I undid the changes to prepare to merge.
It does not skip the first few steps because they finish almost immediately. It skips the expensive steps starting with oneapi install.