Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Selective CI basecd on changes to a domain" #509

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

rscohn2
Copy link
Member

@rscohn2 rscohn2 commented Jun 7, 2024

Reverts #508

The CI runs on pushes to the PR branch and on develop after the PR is merged. The javascript code references an object that is only valid for a PR branch and testing of develop branch fails.

This PR reverts the commit until I have time to fix the issue.

@rscohn2 rscohn2 requested review from sknepper and dnhsieh-intel June 7, 2024 20:30
Copy link
Contributor

@sknepper sknepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, @rscohn2 ! Looking forward to the future fix =)

@rscohn2 rscohn2 merged commit 91a9120 into develop Jun 7, 2024
6 checks passed
@rscohn2 rscohn2 deleted the revert-508-dev/test3-unit-tests branch June 7, 2024 22:23
@rscohn2 rscohn2 mentioned this pull request Jun 13, 2024
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants