Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] add link to unit test readme and use correct github team names for maintainers #520

Merged
merged 9 commits into from
Jun 21, 2024
Merged

[Docs] add link to unit test readme and use correct github team names for maintainers #520

merged 9 commits into from
Jun 21, 2024

Conversation

mkrainiuk
Copy link
Contributor

@mkrainiuk mkrainiuk commented Jun 20, 2024 •
edited
Loading

Description

PR adds a link to oneMKL Testing documentation to CONTRIBUTING.md.

PR adds correct github team names to the list of maintainers in README.md introduced by #516

Fixes uxlfoundation/open-source-working-group#63

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log. N/A, documentation change
  • Have you formatted the code using clang-format? N/A, documentation change

@mkrainiuk mkrainiuk requested a review from a team June 20, 2024 16:13
@mkrainiuk mkrainiuk changed the title Documentation: add link to unit test readme and use correct github team for maintainers Documentation: add link to unit test readme and use correct github team names for maintainers Jun 20, 2024
dnhsieh-intel
dnhsieh-intel reviewed Jun 20, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
dnhsieh-intel
dnhsieh-intel approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dnhsieh-intel dnhsieh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some minor format suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/building_and_running_tests.rst Outdated Show resolved Hide resolved
docs/building_and_running_tests.rst Outdated Show resolved Hide resolved
docs/building_and_running_tests.rst Outdated Show resolved Hide resolved
@mkrainiuk mkrainiuk changed the title Documentation: add link to unit test readme and use correct github team names for maintainers [Docs] add link to unit test readme and use correct github team names for maintainers Jun 21, 2024
@mkrainiuk mkrainiuk merged commit ea623a2 into uxlfoundation:develop Jun 21, 2024
8 checks passed
This was referenced Jun 21, 2024
Closed
Closed
Closed
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
@mkrainiuk @dnhsieh-intel @normallytangent
[Docs] add link to unit test readme and use correct github team names…
7cdd083 
… for maintainers (uxlfoundation#520)

Co-authored-by: Dai-Ni Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhsieh-intel dnhsieh-intel dnhsieh-intel approved these changes

@hgunalan hgunalan hgunalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oneMKL Unit test documentation
3 participants
@mkrainiuk @hgunalan @dnhsieh-intel