[SPARSE] Update sparse_blas calls to function_tables operator[] #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now function_tables operator[] requires a tuple, not a single value. Update call in sparse blas
s-Nick
changed the title
Rbiessy
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Thank you for this fix!
For context this issue was missed as the PR that introduced the changes to the function_tables did not conflict with the sparse PR and the GitHub workflow does not test the sparse domain. @rscohn2 do you know if there is any plan to add the sparse domain to the GitHub workflow? It's not clear to me who is responsible for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
developbranch fails to compile for MKLGPU and MKLCPU backend due to a missing update in function_table calls tooperator[]. It now requires a tuple and not a single value as it was before. This patch updates it.To reproduce the issue, compile even only one of the two backend from scratch enabling all domains.
Checklist
All Submissions
Do all unit tests pass locally? Attach a log.
all_mklgpu_log.txt
all_mklcpu_log.txt
Have you formatted the code using clang-format?
Bug fixes
GitHub issue or in this PR)?