Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated scripts and BLAS list files #620

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

vmalia
Copy link
Contributor

@vmalia vmalia commented Dec 11, 2024

As a result of #598 discussion, this PR removes the outdated scripts and updates the create_new_backend document accordingly.

Document preview: https://github.com/uxlfoundation/oneMath/blob/96e0d13ee2224619af396b892a58926236e36476/docs/create_new_backend.rst

@vmalia vmalia self-assigned this Dec 11, 2024
@vmalia vmalia requested a review from a team as a code owner December 11, 2024 17:42
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, overall!

scripts/generate_cmake.py Show resolved Hide resolved
@vmalia vmalia requested a review from spencerpatty December 12, 2024 19:12
Copy link

@spencerpatty spencerpatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine to me. nice to see the "+" and "-" highlighted in the examples ... makes it simpler to follow what is necessary.
The text changes and removal of python scripts is also good, to focus on most important pieces of changes needed. Approved for merge.

@vmalia vmalia merged commit def5402 into uxlfoundation:develop Dec 12, 2024
9 checks passed
@vmalia vmalia deleted the rm_scripts branch December 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants