fixing userRole for demo game

packages/platform/src/services/GameService.ts

@@ -4,12 +4,7 @@ import { nanoid } from 'nanoid'
 import { none, repeat } from 'ramda'
 import * as yup from 'yup'
 import log from '../lib/logger'
-import {
-  CtxWithFacts,
-  CtxWithFactsAndSchema,
-  CtxWithPrisma,
-  UserRole,
-} from '../types'
+import { CtxWithFacts, CtxWithFactsAndSchema, CtxWithPrisma } from '../types'
 import * as EventService from './EventService'
 
 type Context = CtxWithPrisma<PrismaClient>
@@ -997,12 +992,7 @@ export function computePeriodStartResults(
         const { result: facts, actions } = reducers.PeriodResult.apply(result, {
           type: reducers.PeriodResult.ActionTypes.PERIOD_RESULTS_START,
           payload: {
-            // playerRole: result.player.role ?? result.player.connect.role,
-            // TODO(JJ):
-            // - The game doesn't go to the next period because playerRole = null
-            // - Double-check with RS: shouldn't the player role always be
-            // UserRole.PLAYER?
-            playerRole: UserRole.PLAYER,
+            playerRole: result.player.role ?? result.player.connect.role,
             periodFacts,
           },
         })
@@ -1048,7 +1038,7 @@ export function computePeriodStartResults(
       {
         type: reducers.PeriodResult.ActionTypes.PERIOD_RESULTS_INITIALIZE,
         payload: {
-          playerRole: player.role ?? UserRole.PLAYER,
+          playerRole: player.role,
           periodFacts,
         },
       }

packages/platform/src/types/Mutation.ts

@@ -25,11 +25,13 @@ interface GenerateBaseMutationsArgs {
   reducers?: any
   schemas?: any
   inputTypes?: any
+  // TODO(JJ): is returning void right here? It should return a UserRole, no?
   roleAssigner?: (ix: number) => void
 }
 
 export function generateBaseMutations<PeriodFacts, PeriodSegmentFacts>({
   reducers = defaultReducers,
+  // TODO(JJ): What Is Unset? Why string?
   roleAssigner = () => 'UNSET',
   schemas = defaultSchemas,
   inputTypes = defaultInputTypes,