feature(demo-game): make report's page available for players #78
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| #import "./FGameData.graphql" | ||
| #import "./FPlayerData.graphql" | ||
|
|
||
| query GameWithoutFacts($id: Int) { | ||
| gameWithoutFacts(id: $id) { | ||
| ...GameData | ||
| activePeriod { | ||
| id | ||
| activeSegmentIx | ||
| activeSegment { | ||
| id | ||
| countdownExpiresAt | ||
| countdownDurationMs | ||
| } | ||
| segmentCount | ||
| segments { | ||
| id | ||
| } | ||
| } | ||
| periods { | ||
| id | ||
|
|
||
| index | ||
| activeSegmentIx | ||
|
|
||
| segments { | ||
| id | ||
|
|
||
| index | ||
|
|
||
| countdownExpiresAt | ||
| countdownDurationMs | ||
|
|
||
| learningElements { | ||
| id | ||
| title | ||
| } | ||
|
|
||
| storyElements { | ||
| id | ||
| title | ||
| } | ||
| } | ||
| segmentCount | ||
| } | ||
| players { | ||
| id | ||
|
|
||
| isReady | ||
|
|
||
| role | ||
|
|
||
| number | ||
| name | ||
|
|
||
| facts | ||
|
There was a problem hiding this comment. Security concern: Remove facts field from player data The query still includes the Remove this line to ensure no facts are exposed to non-admin users: - facts |
||
|
|
||
| experience | ||
| experienceToNext | ||
| token | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,6 +27,16 @@ export function generateBaseQueries() { | |
| }, | ||
| }) | ||
|
|
||
| t.field('gameWithoutFacts', { | ||
| type: Game, | ||
| args: { | ||
| id: intArg(), | ||
| }, | ||
| async resolve(_, args, ctx) { | ||
| return GameService.getGame(args, ctx) | ||
| }, | ||
| }) | ||
|
Comment on lines
+30
to
+38
There was a problem hiding this comment. Security concern: Implement facts filtering in resolver The Consider implementing a separate resolver that explicitly filters out facts: t.field('gameWithoutFacts', {
type: Game,
args: {
id: intArg(),
},
async resolve(_, args, ctx) {
- return GameService.getGame(args, ctx)
+ const game = await GameService.getGame(args, ctx)
+ return {
+ ...game,
+ periods: game.periods.map(period => ({
+ ...period,
+ segments: period.segments.map(segment => ({
+ ...segment,
+ facts: undefined
+ }))
+ }))
+ }
},
})
There was a problem hiding this comment. @rschlaefli that's an interesting suggestion ... Maybe we only need one graphql doc? There was a problem hiding this comment.
|
||
|
|
||
| t.field('result', { | ||
| type: PlayerState, | ||
| async resolve(_, args, ctx) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coming from a security perspective, this is not "secure" as the variable can just be changed and the request sent with true to receive all data (even though probably no student ever would do that for a game :D). to make it secure, we would need two requests and authorization such that one request (including facts) is only allowed for the game master, and one request (excluding facts) is accessible to the student. the authorization would work based on the player role.
even if it is not really critical here, I think it would be worth it to do it the right way so that we have 1) a good example for how it should be done and 2) so that you have seen how it works for all of the other game elements where it is more critical to authorize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, I see what you mean - good point :D!
I took a look and modified it to the best of my knowledge -> I basically check with the useSession hook who is authenticated and based on that I load the corresponding graphql doc.
Changing the variable (in the new case) isAdmin, should not be possible, right?
Please have a look and let me know if it's aligning with your description