Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialize dev containers #3928

Draft
wants to merge 6 commits into
base: v3
Choose a base branch
from
Draft

chore: initialize dev containers #3928

wants to merge 6 commits into from

Conversation

rschlaefli
Copy link
Member

@rschlaefli rschlaefli commented Oct 27, 2023


Generated summary (powered by Graphite)

TL;DR

This pull request adds a Dockerfile, devcontainer.json, and docker-compose.yml files to the project. It also includes a rules_devcontainer.yaml file for Traefik configuration. The changes enable the use of a development container with additional features and services.

What changed

  • Added a Dockerfile for the development container.
  • Added a devcontainer.json file for configuring the development container.
  • Added a docker-compose.yml file for defining the services in the development container.
  • Added a rules_devcontainer.yaml file for Traefik configuration.

How to test

  1. Clone the repository.
  2. Build the development container using the Dockerfile.
  3. Start the development container using the docker-compose.yml file.
  4. Verify that the container is running and all services are accessible.
  5. Test the functionality of the application within the development container.

Why make this change

  • The addition of a Dockerfile, devcontainer.json, and docker-compose.yml files allows for the use of a development container, which provides a consistent and isolated environment for development.
  • The inclusion of the rules_devcontainer.yaml file enables Traefik configuration, allowing for routing and load balancing of services within the development container.
  • These changes improve the development experience by providing a standardized and reproducible environment, making it easier to onboard new developers and ensuring consistent behavior across different development machines.

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Oct 27, 2023

2 failed and 3 flaky tests on run #1135 ↗︎

2 15 0 0 Flakiness 3

Details:

Merge 7d5ad89 into dada3da...
Project: klicker-uzh Commit: ec79f213e5 ℹ️
Status: Failed Duration: 05:28 💡
Started: Oct 27, 2023 9:25 PM Ended: Oct 27, 2023 9:30 PM
Failed  live-session-workflow.cy.ts • 1 failed test

View Output Video

Test Artifacts
Different live-session workflows > shows a possible workflow of running a session and answering questions Test Replay Output Screenshots
Failed  questions-workflow.cy.ts • 1 failed test

View Output Video

Test Artifacts
Create questions > creates a KPRIM question Screenshots
Flakiness  live-session-workflow.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Different live-session workflows > creates a session with one block Test Replay Output Screenshots
Flakiness  questions-workflow.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Create questions > creates a multiple choice question Screenshots
Create questions > creates a new question, duplicates it and then deletes the duplicate again Screenshots

Review all test suite changes for PR #3928 ↗︎

@rschlaefli rschlaefli changed the title add initial draft files chore: dev containers Oct 27, 2023
@rschlaefli rschlaefli changed the title chore: dev containers chore: initialize dev containers Oct 27, 2023
@rschlaefli rschlaefli marked this pull request as draft October 28, 2023 15:19
Copy link

aviator-app bot commented Oct 8, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

gitguardian bot commented Oct 8, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1509424 Triggered Generic Password 63487a5 .github/workflows/cypress-testing.yml View secret
13650991 Triggered Generic Password 0d2989e .devcontainer/docker-compose.yml View secret
13650991 Triggered Generic Password 1b6f157 .devcontainer/docker-compose.yml View secret
1509424 Triggered Generic Password 1b6f157 .devcontainer/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

coderabbitai bot commented Oct 8, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant