Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow users to export/import questions via QTI 2.1 #4163

Draft
wants to merge 18 commits into
base: v3
Choose a base branch
from
Draft

feat: allow users to export/import questions via QTI 2.1 #4163

wants to merge 18 commits into from

Conversation

rschlaefli
Copy link
Member

No description provided.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 11, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rschlaefli rschlaefli changed the title feat: QTI feat: allow users to export/import questions via QTI 2.1 Aug 11, 2024
@cypress Cypress
Copy link

cypress bot commented Aug 11, 2024 •
edited
Loading

klicker-uzh    Run #3219

Run Properties:  status check passed Passed #3219  •  git commit 2bcc86156d ℹ️: Merge 4813daa253017e6c7064243c22fdc027234adf4b into ef4e2d4611acf27667e3b3ed5291...
Project klicker-uzh
Run status status check passed Passed #3219
Run duration 11m 45s
Commit git commit 2bcc86156d ℹ️: Merge 4813daa253017e6c7064243c22fdc027234adf4b into ef4e2d4611acf27667e3b3ed5291...
Committer Roland Schläfli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2024
View reviewed changes
packages/qti/testing_lxml.py Outdated
</assessmentItem>"""

# Parse the XML content
parser = etree.XMLParser(remove_blank_text=True)

Check failure

Code scanning / SonarCloud

XML parsers should not be vulnerable to XXE attacks High test

Disable access to external entities in XML parsing. See more on SonarCloud
packages/qti/testing_lxml.py Outdated
print(f" Feedback: {feedback}")

# Validate against QTI 2.1 schema
xsd_parser = etree.XMLParser()

Check failure

Code scanning / SonarCloud

XML parsers should not be vulnerable to XXE attacks High test

Disable access to external entities in XML parsing. See more on SonarCloud
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@aviator-app Aviator app
Copy link

aviator-app bot commented Oct 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rschlaefli @sjschlapbach