Handles various Discord markdowns #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenylshima
requested changes
Mar 4, 2022
phenylshima
reviewed
Mar 4, 2022
Comment on lines
+21
to
+22
| const MARKDOWN2_REPLACER = [/([*_~`])\1(.+?)\1\1/gs, '$2 '] as const; | ||
| const MARKDOWN1_REPLACER = [/([_`])(.+?)\1/gs, '$2 '] as const; |
There was a problem hiding this comment.
/([*_~`]{2}|[_`])(.+?)\1/gs
とすれば一つにまとめられるのでは？
phenylshima
reviewed
Mar 4, 2022
| const MARKDOWN1_REPLACER = [/([_`])(.+?)\1/gs, '$2 '] as const; | ||
| const ITALIC_REPLACER = [/\*(.+?)\*/g, '$1 '] as const; | ||
| // eslint-disable-next-line no-irregular-whitespace | ||
| const QUOTE_REPLACER = [/^> (.*[^\s ])$/g, '$1 '] as const; |
There was a problem hiding this comment.
これだと末尾に空白文字のある行だけが置換されません。
例：
> a
> b
(> aの行の末尾にだけスペースがある)
だと、> bの行はマッチしますが、> aの行はマッチしません。
@femshima (略).test.js にということでよろしいですか？ |
|
@arx-ein リマインド． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord markdown の記号が読まれないように