Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: bump github.com/jhump/protoreflect from 1.15.0 to 1.15.1 #2379

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 6, 2023

Bumps github.com/jhump/protoreflect from 1.15.0 to 1.15.1.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.15.1

This is small bugfix release to address regressions reported in v1.15.0.

"github.com/jhump/protoreflect/desc/protoparse"

Changes/fixes:

  • As of v1.15.0, descriptors returned from this package would include dynamic extension fields to represent option values for custom options that were defined in the set of files being compiled. This was a regression from all previous versions, where custom options were represented using statically known extension fields (i.e. extensions that were generated to Go code and linked into the calling program) or as unrecognized fields. This break some usages, where code was using type assertions of the extension value to a generated struct (which fails when the value is a dynamic message value). This has been fixed, and the behavior from v1.14.1 and before has been restored.
  • As of v1.15.0, a data race was possible. This is was a regression, where #236 revealed its ugly head again. The issue would occur if a parse operation used the Parser.LookupImport or Parser.LookupImportProto field to supply some dependencies as descriptors instead of as source. The race occurred when the same descriptor was referenced from different, concurrent parse operations: one goroutine would modify the descriptor during linking, while another goroutine was trying to access it (without synchronization). It has now been fixed (via a fix in the underlying protocompile library: bufbuild/protocompile#103).
Commits
  • 81aa758 hack: change internal package name for grpc.reflection.v1 to prevent possible...
  • 7923b75 protoparse: fixes to issues reported in v1.15.0 (#554)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [github.com/jhump/protoreflect](https://github.com/jhump/protoreflect) from 1.15.0 to 1.15.1.
- [Release notes](https://github.com/jhump/protoreflect/releases)
- [Commits](jhump/protoreflect@v1.15.0...v1.15.1)

---
updated-dependencies:
- dependency-name: github.com/jhump/protoreflect
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (aa32199) 39.08% compared to head (022cd7b) 39.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2379      +/-   ##
==========================================
- Coverage   39.08%   39.06%   -0.03%     
==========================================
  Files         617      617              
  Lines       37035    37035              
==========================================
- Hits        14474    14466       -8     
- Misses      20970    20977       +7     
- Partials     1591     1592       +1     
Impacted Files Coverage Δ
app/proxyman/outbound/errors.generated.go 0.00% <0.00%> (-100.00%) ⬇️
common/task/task.go 88.88% <0.00%> (-7.41%) ⬇️
app/proxyman/outbound/handler.go 30.23% <0.00%> (-3.49%) ⬇️
app/stats/channel.go 97.75% <0.00%> (-2.25%) ⬇️
common/session/context.go 56.66% <0.00%> (-1.67%) ⬇️
proxy/vmess/outbound/outbound.go 58.26% <0.00%> (-0.79%) ⬇️
common/protocol/quic/qtls_go119.go
common/protocol/quic/qtls_go120.go 100.00% <0.00%> (ø)
transport/pipe/impl.go 89.89% <0.00%> (+2.02%) ⬆️
transport/internet/websocket/connection.go 20.18% <0.00%> (+3.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2023

Superseded by #2662.

@dependabot dependabot bot closed this Aug 23, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/jhump/protoreflect-1.15.1 branch August 23, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant