[IO-1278][IO-1277] Core Items/Folders apis #691
Conversation
IO-1278 Core: Retrieve Items
Create methods for:
|
darwin/future/meta/objects/stage.py
Outdated
| return [ | ||
| [edge.id, edge.source_stage_id, edge.target_stage_id] | ||
| for edge in self._element.edges | ||
| if edge.source_stage_id and edge.target_stage_id | ||
| ] |
There was a problem hiding this comment.
@JBWilkie source_stage_id and target_stage_id are optional so they can be None. Which means this comprehension without the if check actually returns a List[List[UUID | None]]. Let me know if this change doesn't make sense though and you want the None's
There was a problem hiding this comment.
Can't see a use case for why the Nones would be needed but you never know
There was a problem hiding this comment.
I actually changed this so that it returns the WFEdgeCore items instead of the IDs within them, not sure why I didn't do this originally
This means we don't need to worry about this if check
There was a problem hiding this comment.
Looking good, hold off merge until we've worked out data structs in call later, and potentially until @JBWilkie responds on the points about none filtering, although I don't think that's as blocking.
There was a problem hiding this comment.
I like this stuff especially 😉
| return v | ||
|
|
||
|
|
||
| class ItemSlot(DefaultDarwin): |
There was a problem hiding this comment.
This is the main one I've changed in my branch
|
|
||
|
|
||
| class Item(DefaultDarwin): | ||
| name: str |
There was a problem hiding this comment.
And this is where we'll have to figure it out between us.
| @pytest.fixture | ||
| def base_items_json(base_items: List[Item]) -> List[dict]: | ||
| items = [item.dict() for item in base_items] | ||
| # json library doesn't support UUIDs so need to be str'd |
There was a problem hiding this comment.
Yeah, what's with this? Every time I hit this, I'm tempted to write:
class JsonableUUID(UUID):
...fix for this...
darwin/future/meta/objects/stage.py
Outdated
| return [ | ||
| [edge.id, edge.source_stage_id, edge.target_stage_id] | ||
| for edge in self._element.edges | ||
| if edge.source_stage_id and edge.target_stage_id | ||
| ] |
There was a problem hiding this comment.
Can't see a use case for why the Nones would be needed but you never know
Problem
No ability to retrieve or manage items and folders
Solution
Changelog
Beggining of support for items object, including apis