[AI-1287] fixed the siutation when a user pass only a image #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristofferEdlund
changed the title
dorfmanrobert
approved these changes
Oct 23, 2023
… is to throw an error and not let the user include images without annotations
| output_annotation["masks"] = torch.tensor([]) | ||
|
|
||
| if "area" in annotation: | ||
| if "masks" in output_annotation and output_annotation["masks"].numel() > 0: |
There was a problem hiding this comment.
stylistic choice: could use masks and bboxes variables since have them but up to you
There was a problem hiding this comment.
I think we keep at as it is, masks and bboxes are not the same since we do some conversion. masks for example is a list, and does not have .numel
|
left one stylistic comment abt using existing variables or not that I leave up to you, otherwise all good! |
ChristofferEdlund
deleted the
ai-1287-fixed-darwin-albumentation-transform-format-when-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
One should be able to user the albumentations transform in this way:
Right now the transform output's a (img, target) tuple even when only an image is passed.
Solution
Add a check if there is only an image as input, and return only image if that is the case.
Changelog