[IO-1800] Set priority #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO-1800 Core: Edit items: Set priority
|
Nathanjp91
approved these changes
Oct 24, 2023
| api_client: ClientCore, | ||
| team_slug: str, | ||
| priority: int, | ||
| filters: Optional[Dict[str, UnknownType]] = None, |
There was a problem hiding this comment.
This is not blocking at all but interested here on your thoughts on
filters: Optional[...] = None vs filters: ... = {} Is it more pythonic to assume None's or empty objects? The former does tend to lead to requiring more typecheck guards to satisfy mypy/pylance with like assert filters is not None etc, which does feel more verbose than required sometimes.
There was a problem hiding this comment.
but obviously, it is a bit more clear that filters isn't required via the Optional[...] = None approach
There was a problem hiding this comment.
Nah, good point, I like the default in this backend code, will take this suggestion
owencjones
added a commit
that referenced
this pull request
Oct 24, 2023
This reverts commit 21cbfe0.
owencjones
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No current access to setting priority of items
Solution
Implemented priority setter.
Changelog
Priority setting method in core
Tests