-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IO-2040][external] Fix for NifTI exports that include filenames with dots #705
Conversation
IO-2040 BUG: There is an issue exporting NIfTI that is not an issue for Darwin JSON. Seems to be an issue with having periods in the filename.
BUG submission from: Jade Yip I'm not sure why periods '.' are not allowed in the V7 NIfTI basename (e.g., __1.0mm__AXIAL.nii.gz) Possible solution: only parse the last two suffixes from right prior to returning error darwin-py/darwin/exporter/formats/nifti.py Line 138 in be3ba68
Is there a way to rename existing V7 resources and/or export the completed NIfTI volumes with python pathlib suffixes > 2 without issue? Dataset: Assigned CSM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible issue but rest of the code looks good.
Problem
As described in IO-2040, NifTI exports of files with filenames containing dots would fail due to there being too many suffixes
Solution
Add logic to extract the last 2 suffixes of each filename while preserving the existing error checking logic
Changelog
Fixed a bug preventing NifTI exports that include filenames with dots