Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PY-384] Set item layout #710

Merged
merged 7 commits into from
Nov 10, 2023
Merged

[PY-384] Set item layout #710

merged 7 commits into from
Nov 10, 2023

Conversation

Nathanjp91
Copy link
Contributor

Problem

Lacking set item layout api access

Solution

add function to use set_item_layout

Changelog

setting item layout now available in core

@linear Linear
Copy link

linear bot commented Nov 7, 2023

PY-377 [Core] Item Management

See scoping in:

https://www.notion.so/v7labs/Item-Management-Functionality-Scoping-df5f846a135e46e1bf31c473afda32ee#c41209384c464532a53a779352d0283f

@Nathanjp91 Nathanjp91 changed the title [PY-377] Set item layout [PY-384] Set item layout Nov 7, 2023
@linear Linear
Copy link

linear bot commented Nov 7, 2023

PY-384 Core: Edit items: Set layout

https://www.notion.so/v7labs/Item-Management-Functionality-Scoping-df5f846a135e46e1bf31c473afda32ee#c93dd9600c9b47b394df6660276d490d

set_item_layout(client, id, layout)
# client: Client
# id: str, validatable as UUID
# layout: layout data object - see swagger.

JBWilkie
JBWilkie reviewed Nov 8, 2023
View reviewed changes
darwin/future/tests/core/items/test_set_item_layout.py Outdated
status=400,
)

with pytest.raises(HTTPError):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made in PY-386 would cause this to raise a BadRequest error instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make those changes once we merge yours

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good heads up @JBWilkie, 'cause that could've been a confusing test result change to see.

@linear Linear
Copy link

linear bot commented Nov 8, 2023

PY-377 [Core] Item Management

See scoping in:

https://www.notion.so/v7labs/Item-Management-Functionality-Scoping-df5f846a135e46e1bf31c473afda32ee#c41209384c464532a53a779352d0283f

owencjones
owencjones approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@owencjones owencjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, all LGTM, nice simple one

@Nathanjp91 Nathanjp91 merged commit 9a6d191 into master Nov 10, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWilkie JBWilkie JBWilkie left review comments

@owencjones owencjones owencjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nathanjp91 @owencjones @JBWilkie