-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ai-1477]-darwin-v2-export-fix #721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almazan
approved these changes
Nov 15, 2023
whilefalse
approved these changes
Nov 15, 2023
ChristofferEdlund
changed the title
[Ai 1410]-darwin-v2-export-fix
[Ai-1410]-darwin-v2-export-fix
Nov 16, 2023
…le to use all or only non empty annotations to local dataset class
Nathanjp91
suggested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff to look at.
rslota
reviewed
Nov 27, 2023
…e when writing to file now
Nathanjp91
approved these changes
Dec 5, 2023
Nathanjp91
changed the title
[Ai-1410]-darwin-v2-export-fix
[Ai-1477]-darwin-v2-export-fix
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent changes to darwin introduced local datasets loading of only
darwin_v2
format.When converting video datasets to images by using the split function
split_video_annotations
darwin-py/darwin/dataset/remote_dataset.py
Line 143 in 79fd606
there are usage of a darwin export will not generate v2 annotations, instead it generates this json (assumably v1)
darwin-py/darwin/exporter/formats/darwin.py
Line 17 in 79fd606
Leading to our dataloaders not being able to load any data that has been converted from video now that
v2
format is enforced.Solution
Updating the darwin v2 export function
build_image_annotation
to generate validv2
image annotations.It's only used in that one place above currently so changing it should fix our problem and not introduce any unwanted issues.
Changelog
split_video_annotations
convertion so it generates valid per-image darwinv2
annotations.keep_empty_annotations
arg (default is False)