[PY-573] Darwin Future Properties base objects #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathanjp91
commented
Dec 8, 2023
| @@ -51,9 +51,9 @@ def parse_path(path: Path) -> Optional[List[dt.AnnotationFile]]: | |||
| file_annotation_map[filename].append(annotation) | |||
There was a problem hiding this comment.
this file was included because I accidentally ran linter on darwin rather than darwin/future by mistake. Ignore it for the PR but will include it to keep old code linted.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No support exists for new Properties features loading into annotations
Solution
Write pydantic objects to handle the upcoming properties features. Includes seperate objects to parse the metadata.json files + some base DarwinV2 annotations that these properties will be listed in.
Changelog
Basic Support for Property fields added