[PY-620] Add properties checker util functions #748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathanjp91
suggested changes
Dec 18, 2023
| @@ -267,6 +268,45 @@ def _resolve_annotation_classes( | |||
| return local_classes_not_in_dataset, local_classes_not_in_team | |||
|
|
|||
|
|
|||
| def build_list_properties(annotations: List[dt.Annotation]) -> List[SelectedProperty]: | |||
| return [prop for annotation in annotations for prop in annotation.properties or []] | |||
There was a problem hiding this comment.
I think this might need to also return the annotation.class info alongside the SelectedProperty, in a similar vein to metadata.json. See slack for more info.
| team_properties: List[FullProperty], import_properties: List[SelectedProperty] | ||
| ) -> List[SelectedProperty]: | ||
| missing_properties: List[SelectedProperty] = [] | ||
| team_properties_lookup = {prop.name: prop for prop in team_properties} |
There was a problem hiding this comment.
Like the key lookup approach, very nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lacking support for properties checker util functions
Solution
adds in util functions for checking properties
build_list_properties(List[dt.Annotation]) -> List[SelectedProperty]properties_missing(List[FullProperty], List[SelectedProperty]) -> List[SelectedProperty]mismatched_properties(List[FullProperty], List[SelectedProperty]) -> List[SelectedProperty]TODO:
Changelog
Add properties checker util functions