Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY-623] Get team properties backported to client #749

Merged
merged 46 commits into from
Dec 15, 2023
Merged

[PY-623] Get team properties backported to client #749

merged 46 commits into from
Dec 15, 2023

Conversation

saurbhc
Copy link
Member

@saurbhc saurbhc commented Dec 13, 2023

Problem

Will need to backport some api calls to client class, getting team properties which will be defined in future code.

Solution

  • add client.get_team_properties method
  • backport future client

TODO:

Changelog

Get team properties backported to client

@saurbhc saurbhc added the enhancement New feature or request label Dec 13, 2023
@saurbhc saurbhc self-assigned this Dec 13, 2023
Copy link

linear bot commented Dec 13, 2023

@saurbhc saurbhc marked this pull request as ready for review December 13, 2023 11:29
@saurbhc saurbhc requested a review from Nathanjp91 December 13, 2023 11:30
Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see a test (in future tests module) re config from old as well as tests in the older code in the style of responses. We're introducing api calls for properties that clients will be using so need to make reasonably sure that they don't break if we change things in darwin.future now.

darwin/config.py Outdated Show resolved Hide resolved
darwin/config.py Outdated Show resolved Hide resolved
darwin/client.py Outdated Show resolved Hide resolved
@saurbhc saurbhc requested a review from Nathanjp91 December 13, 2023 16:59
Copy link
Contributor

@Nathanjp91 Nathanjp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: I renamed include_options -> include_property_values because of discussion on project_properties about removing 'options' from the objects in favour of property_values instead. So just to keep consistency

@saurbhc saurbhc merged commit 7eac38c into master Dec 15, 2023
13 checks passed
@saurbhc saurbhc deleted the PY-623 branch December 15, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants