-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PY-623] Get team properties backported to client #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see a test (in future tests module) re config from old as well as tests in the older code in the style of responses. We're introducing api calls for properties that clients will be using so need to make reasonably sure that they don't break if we change things in darwin.future now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: I renamed include_options -> include_property_values because of discussion on project_properties about removing 'options' from the objects in favour of property_values instead. So just to keep consistency
Problem
Will need to backport some api calls to client class, getting team properties which will be defined in future code.
Solution
client.get_team_properties
methodTODO:
Changelog
Get team properties backported to client