Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-3424][Externa] Added Dockerfile #898

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[DAR-3424][Externa] Added Dockerfile #898

merged 1 commit into from
Aug 15, 2024

Conversation

JBWilkie
Copy link
Collaborator

Problem

There have historically been many requests to use darwin-py as cloud infrastructure. These have been tricky to support due to build dependencies in darwin-py

Solution

This PR allows darwin-py to be deployed easily on a container, removing the difficulties of build dependencies

Changelog

Added Dockerfile for darwin-py

Copy link

linear bot commented Aug 14, 2024

@wiz-inc-4ad3b29aa7
Copy link

Wiz Scan Summary

IaC Misconfigurations 0C 1H 9M 1L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 9M 1L 0I
Secrets 0🔑

@shernshiou
Copy link
Contributor

Overall the Dockerfile looks good, however I am not sure about YOUR_ENV. If I understand correctly, the purpose is to select whether it is development or production. Since the purpose of this Dockerfile is solely for development purpose, we can assume that the environment is development and remove YOUR_ENV.

Otherwise, we can find other alternative name to YOUR_ENV to correctly describe it's purpose.

@JBWilkie
Copy link
Collaborator Author

Overall the Dockerfile looks good, however I am not sure about YOUR_ENV. If I understand correctly, the purpose is to select whether it is development or production. Since the purpose of this Dockerfile is solely for development purpose, we can assume that the environment is development and remove YOUR_ENV.

Otherwise, we can find other alternative name to YOUR_ENV to correctly describe it's purpose.

The intention is actually to allow people to deploy darwin-py easily in a production environment. We have fairly regular requests from clients who want to import annotations or data as part of an automated pipeline they have running in cloud infra. This can be tricky with darwin-py due to it's somewhat complex dependencies, so the idea is that a Docker image solves this

@JBWilkie JBWilkie merged commit 9442d82 into master Aug 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants