[DAR-3431][External] Adding passing E2E tests as a requirement to release #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBWilkie
commented
Aug 20, 2024
| @@ -7,6 +7,7 @@ on: | |||
| pull_request: | |||
| paths: | |||
| - "e2e_tests/**" | |||
| workflow_call: | |||
There was a problem hiding this comment.
Need this trigger to allow it to be called during the release event
JBWilkie
commented
Aug 20, 2024
| @@ -957,7 +957,7 @@ def import_annotations( # noqa: C901 | |||
|
|
|||
| def import_annotation(parsed_file): | |||
| image_id = remote_files[parsed_file.full_path]["item_id"] | |||
| default_slot_name = remote_files[parsed_file.full_path]["slot_names"] | |||
| default_slot_name = remote_files[parsed_file.full_path]["slot_names"][0] | |||
There was a problem hiding this comment.
Bonus bug fix when importing annotation files that don't specify a slot name. This is one of the bugs we would have caught with E2E failures
JBWilkie
commented
Aug 20, 2024
Comment on lines
49
to
+60
| if: failure() && github.event_name == 'schedule' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Notify Slack | ||
| uses: ./.github/workflows/JOB_slack_message.yml | ||
| with: | ||
| secrets: inherit | ||
| icon: ":warning:" | ||
| at_team: true | ||
| message: | | ||
| *Nightly E2E run failed* | ||
|
|
||
| :link: | ||
| - https://github.com/v7labs/darwin-py/actions/runs/${{ github.run_id }} | ||
| :warning: ${{ github.workflow }} failed. | ||
| uses: ./.github/workflows/JOB_slack_message.yml | ||
| with: | ||
| message: | | ||
| *Nightly E2E run failed* | ||
|
|
||
| :link: | ||
| - https://github.com/v7labs/darwin-py/actions/runs/${{ github.run_id }} | ||
| :warning: ${{ github.workflow }} failed. | ||
| icon: ":warning:" | ||
| at_team: true | ||
| secrets: inherit |
There was a problem hiding this comment.
This part calls the slack message job as a job instead of an action. I'm not sure how this ever used to work, since as far as I can tell this should only ever work if called as a job
I'm not sure how this ever used to work
dorfmanrobert
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've recently had a couple annotation import bugs that would have been caught by E2E tests. However:
Solution
This PR:
Changelog
Introduced a requirement for E2E tests to pass before new darwin-py versions can be released