[DAR-2860][External] Import of item-level properties #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment from metadata & imported files
darwin/importer/importer.py
Outdated
| @@ -318,12 +352,104 @@ def _update_payload_with_properties( | |||
| annotation["annotation_properties"] = dict(_map) | |||
|
|
|||
|
|
|||
| def _update_payload_with_item_level_properties( | |||
There was a problem hiding this comment.
Lets rename this and update the description unless we are updating the payload like we do in _update_payload_with_properties, since its not updating the payload but just returning the serialized_item_level_properties
dorfmanrobert
requested changes
Oct 10, 2024
There was a problem hiding this comment.
A handful of small things, there is one that regards the actual logic though: #936 (comment)
dorfmanrobert
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
darwin-py cannot currently import item-level properties
Solution
Changelog
Support for importing item-level properties