Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-5293][External] Removed {item_path}/{item_name} validation on push #984

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

JBWilkie
Copy link
Collaborator

Problem

This validation logic introduced in DAR-3846 only covers a very rare edge case, and makes very expensive API calls for every push operation

Solution

We remove this validation and may re-introduce this validation on the backend in the future

Changelog

Removed expensive pre-push validation from darwin-py that provided a negligible benefit

Copy link

linear bot commented Dec 18, 2024

@JBWilkie JBWilkie merged commit e053c42 into master Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants