[DAR-5421] Support for non-axial NifTI annotation imports and exports #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBWilkie
commented
Feb 14, 2025
JBWilkie
commented
Feb 14, 2025
dorfmanrobert
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently when importing or exporting annotations in the
NifTIformat, it's assumed the primary plane of the target slot axial. This is not always the case. Assuming anAXIALprimary plane is problematic because incorrectpixdimvalues are selected for scaling and slicingSolution
This PR makes changes to take the primary plane of the target slot into account when scaling and slicing
NifTIannotations on import and exportChangelog
Added support for importing and exporting non-axial
NifTIvolumes as annotations