fix: make Lumo font custom properties work for vaadin-select #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugur-vaadin
approved these changes
Apr 4, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 4, 2024
…7300) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7234
When introducing custom CSS properties for font-weight, we missed to use it in
vaadin-select.Regarding font-size property, it is used but slotted
vaadin-select-itemoverrides its value.Note: I'm not sure why font-weight is set to
500for select and not400like in text-field etc.Type of change