Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make disabled menu bar buttons accessible with feature flag #8518

Merged
merged 41 commits into from
Jan 21, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jan 16, 2025

Description

To improve accessibility, the PR introduces an option to make disabled menu bar buttons focusable so that screen readers can reach and announce them to users, including their tooltips. This behavior is currently experimental and can be enabled with the feature flag:

// Set before any menu bar is added to the DOM.
window.Vaadin.featureFlags.accessibleDisabledButtons = true;

Note

I recommend reviewing with "Hide whitespaces" to hide irrelevant changes from the diff.

Depends on

Part of #4585

Type of change

  • Feature

@vursen vursen force-pushed the feat/focusable-disable-components branch from 911d0b4 to 35f06ee Compare January 16, 2025 09:12
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from b5333bb to 60802ea Compare January 16, 2025 09:13
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 3db870e to ec9cb70 Compare January 16, 2025 12:19
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 48007f1 to a9ed5ec Compare January 17, 2025 05:45
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from a9ed5ec to 699c5e5 Compare January 17, 2025 07:55
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 699c5e5 to 3f14b15 Compare January 17, 2025 10:59
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 3f14b15 to 93efcd6 Compare January 17, 2025 11:05
@vursen vursen marked this pull request as ready for review January 17, 2025 11:05
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 93efcd6 to 0fcd8b1 Compare January 17, 2025 11:14
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 0fcd8b1 to 4ae12c5 Compare January 20, 2025 07:15
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 4ae12c5 to eff853a Compare January 20, 2025 08:17
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 9958813 to d970ca9 Compare January 20, 2025 08:23
@vursen vursen force-pushed the feat/focusable-disabled-menu-buttons branch from 1bc18f4 to 83b1731 Compare January 21, 2025 10:16
Base automatically changed from feat/focusable-disable-components to main January 21, 2025 11:16
@vursen vursen changed the title feat: make disabled menu bar buttons focusable with feature flag feat: make disabled menu bar buttons accessible with feature flag Jan 21, 2025
@vursen vursen merged commit 360bba2 into main Jan 21, 2025
9 checks passed
@vursen vursen deleted the feat/focusable-disabled-menu-buttons branch January 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants