-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make disabled menu bar buttons accessible with feature flag #8518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
feat/focusable-disable-components
branch
from
January 16, 2025 09:12
911d0b4
to
35f06ee
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 16, 2025 09:13
b5333bb
to
60802ea
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 16, 2025 12:19
3db870e
to
ec9cb70
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 17, 2025 05:45
48007f1
to
a9ed5ec
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 17, 2025 07:55
a9ed5ec
to
699c5e5
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 17, 2025 10:59
699c5e5
to
3f14b15
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 17, 2025 11:05
3f14b15
to
93efcd6
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 17, 2025 11:14
93efcd6
to
0fcd8b1
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 20, 2025 07:15
0fcd8b1
to
4ae12c5
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 20, 2025 08:17
4ae12c5
to
eff853a
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 20, 2025 08:23
9958813
to
d970ca9
Compare
vursen
force-pushed
the
feat/focusable-disabled-menu-buttons
branch
from
January 21, 2025 10:16
1bc18f4
to
83b1731
Compare
vursen
requested review from
sissbruecker and
tomivirkki
and removed request for
sissbruecker and
tomivirkki
January 21, 2025 11:18
1 task
sissbruecker
approved these changes
Jan 21, 2025
Quality Gate passedIssues Measures |
tomivirkki
approved these changes
Jan 21, 2025
vursen
changed the title
feat: make disabled menu bar buttons focusable with feature flag
feat: make disabled menu bar buttons accessible with feature flag
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve accessibility, the PR introduces an option to make disabled menu bar buttons focusable so that screen readers can reach and announce them to users, including their tooltips. This behavior is currently experimental and can be enabled with the feature flag:
Note
I recommend reviewing with "Hide whitespaces" to hide irrelevant changes from the diff.
Depends on
Part of #4585
Type of change