Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add layout improvements behind feature flag #8552

Merged
merged 13 commits into from
Jan 31, 2025
Prev Previous commit
Next Next commit
update feature flag name
  • Loading branch information
sissbruecker committed Jan 31, 2025
commit 112c7575cb34c84c1a2fc0207324b1a97acd7d1e
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ export const baseStyles = css`
// using `HasSize.setSizeFull()` and others, get additional styles so that they effectively take the remaining space in
// the layout, rather than explicitly use 100% width/height. The respective data attributes are set by Flow's `HasSize`
// class.
const enableLayoutImprovements = window.Vaadin.featureFlags.layoutImprovements;
const enableLayoutImprovements = window.Vaadin.featureFlags.layoutComponentImprovements;
const layoutImprovementStyles = css`
::slotted([data-width-full]) {
flex: 1;
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
window.Vaadin ??= {};
window.Vaadin.featureFlags ??= {};
window.Vaadin.featureFlags.layoutImprovements = true;
window.Vaadin.featureFlags.layoutComponentImprovements = true;
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ export const baseStyles = css`
// using `HasSize.setSizeFull()` and others, get additional styles so that they effectively take the remaining space in
// the layout, rather than explicitly use 100% width/height. The respective data attributes are set by Flow's `HasSize`
// class.
const enableLayoutImprovements = window.Vaadin.featureFlags.layoutImprovements;
const enableLayoutImprovements = window.Vaadin.featureFlags.layoutComponentImprovements;
const layoutImprovementStyles = css`
::slotted([data-height-full]) {
flex: 1;
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
window.Vaadin ??= {};
window.Vaadin.featureFlags ??= {};
window.Vaadin.featureFlags.layoutImprovements = true;
window.Vaadin.featureFlags.layoutComponentImprovements = true;